]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
Notification: don't expand the content on a destroyed notification
authorGiovanni Campagna <gcampagna@src.gnome.org>
Wed, 15 Jan 2014 17:05:45 +0000 (18:05 +0100)
committerGiovanni Campagna <gcampagna@src.gnome.org>
Sun, 19 Jan 2014 14:59:18 +0000 (15:59 +0100)
If the notification is destroyed between an allocate and the redraw,
the meta_later is invoked on a destroyed object, and fails because
the clutter calls are invalid at that point.

https://bugzilla.gnome.org/show_bug.cgi?id=722547

js/ui/messageTray.js

index 6503611154cc64dc908f965bca1d39e2c10440e8..f3806b7e674ac52ae0f3a3aabfbaf8429282bc98 100644 (file)
@@ -1001,6 +1001,9 @@ const Notification = new Lang.Class({
             Meta.later_add(Meta.LaterType.BEFORE_REDRAW,
                            Lang.bind(this,
                                      function() {
+                                         if (this._destroyed)
+                                             return false;
+
                                         if (this._canExpandContent()) {
                                             this._addBannerBody();
                                             this._table.add_style_class_name('multi-line-notification');